thelabdude commented on pull request #1781:
URL: https://github.com/apache/lucene-solr/pull/1781#issuecomment-680928789
@MarcusSorealheis thanks for helping out with this branch. The
`SolrPingTest` passes for me locally w/o your fixes, which is not surprising
for ignored tests as a previous issue may have been resolved by other changes
in this very active branch. However, I'm not clear on the reasons for your
changes in the `SolrZkServer` class? For instance, `server.addr` is a
`InetSocketAddress` so doing an `equals` on that to a String is not what we
want here:
```
- if (server.addr.getHostName().equals(myHost)) {
+ if (server.addr.equals(myHost)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
