janhoy commented on pull request #1362: URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-681924972
Perhaps this can be more dynamic, i.e. we require whatever claim that is configured for `principalClaim` in the config. This defaults to `sub`, but if someone configures e.g. `principalClaim: userid` then we should no longer require the `sub` claim. So I claim that we don't need an extra config option. Solr needs a principal ID anyway, so we have to require *something*. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
