[ 
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189738#comment-17189738
 ] 

Robert Muir commented on LUCENE-9500:
-------------------------------------

I think as a workaround we should arraycopy preset dictionary to a byte[] so 
that we'll have a 0-based offset. We'll need to keep it around for quite some 
time to avoid corruption if someone has an impacted JDK.

It seems to only impact compression too, not decompression. 
Inflater.setDictionary actually uses its "off" parameter and we already always 
use a 0-based offset for inflation, so we don't need any workaround at query 
time, just when indexing. 

> Did we hit a DEFLATE bug?
> -------------------------
>
>                 Key: LUCENE-9500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9500
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: PresetDictTest.java, test_data.txt
>
>
> I've been digging 
> [https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-NightlyTests-master/23/]
>  all day and managed to isolate a simple reproduction that shows the problem. 
> I've been starring at it all day and can't find what we are doing wrong, 
> which makes me wonder whether we're calling DEFLATE the wrong way or whether 
> we hit a DEFLATE bug. I've looked at it so much that I may be missing the 
> most obvious stuff.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to