uschindler commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484222322
##########
File path:
lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java
##########
@@ -263,7 +263,7 @@ public void testThrowingException() throws Exception {
PrintWriter pw = new PrintWriter(sw);
Review comment:
Yeah, I added this only for my personal debugging, because this test
fails with my change (as the expression is hidden from the stack trace, so the
"contains" does not work. But when it fails, you don't see what should be there.
Assertj is really better as it automatically prints and also shortens the
printout to only relevant part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
