[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192970#comment-17192970
]
Mike Drob commented on SOLR-14846:
----------------------------------
Individually calling ofNullable and calling orElse* on an Optional is fine,
it's the immediate combination of the two that is unnecessary. I'm not sure
that forbiddenAPI is expressive enough to select for that, but I also haven't
spent a ton of time investigating it and would prefer to defer to an expert in
the library.
Can forbiddenAPI keep us from declaring methods with Optional parameters?
IntelliJ has an inspection/warning/error for that, btw.
> Avoid use of Optional.ofNullable.orElse in the same line
> --------------------------------------------------------
>
> Key: SOLR-14846
> URL: https://issues.apache.org/jira/browse/SOLR-14846
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Optional was meant to be used in public APIs to convey to the caller that
> they really need to null-check, not as an internal class to avoid doing our
> own null checks. There are better methods in {{Objects}} for that if we want
> them.
> See also Brian Goetz at JavaOne - https://youtu.be/MFzlgAuanU0?t=2719
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
