jpountz commented on a change in pull request #1834: URL: https://github.com/apache/lucene-solr/pull/1834#discussion_r487788434
########## File path: lucene/CHANGES.txt ########## @@ -204,7 +204,8 @@ Improvements * LUCENE-9446: In BooleanQuery rewrite, always remove MatchAllDocsQuery filter clauses when possible. (Julie Tibshirani) -* LUCENE-9501: Improve how Asserting* test classes handle singleton doc values. +* LUCENE-9501: Improve coverage for Asserting* test classes: make sure to handle singleton doc + values, and sometimes wrap Scorers by default. (Julie Tibshirani) Review comment: I'm not sure I'd understand what "sometimes wrap scorers" would mean as a user reading the changelog. Maybe say something along the lines of "sometimes exercise the `Weight#scorer` API rather than `Weight#bulkScorer` for top-level queries". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org