[ 
https://issues.apache.org/jira/browse/SOLR-14856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195450#comment-17195450
 ] 

Houston Putman commented on SOLR-14856:
---------------------------------------

I understand your concern. Initially I did this just as a POC, but after 
looking at the available configurations I think it would be a good addition.

Github Actions allow you to only run a specified task if certain paths are 
changed in the PR. So by setting those paths to {{solr/docker}}, {{solr/bin}}, 
{{solr/packaging}} and {{solr/contrib/prometheus-exporter/bin}} for the Docker 
tests, we can test those components fairly well without affecting PRs for other 
components.

But this was just an idea I had, It's ok if the consensus is that the 
cost/reward is not there.

> Add docker build & tests as a github action
> -------------------------------------------
>
>                 Key: SOLR-14856
>                 URL: https://issues.apache.org/jira/browse/SOLR-14856
>             Project: Solr
>          Issue Type: Improvement
>          Components: Docker, github
>            Reporter: Houston Putman
>            Assignee: Houston Putman
>            Priority: Minor
>
> Currently we only run precommit as a github action. For master (9.0+) only, 
> we could add building and testing the Solr docker image as a test as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to