tflobbe commented on pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#issuecomment-692195569
> I wish we followed REST approaches for so many of our API's I wish that too, but Solr APIs aren't REST as of today ([not even V2 API is fully REST, and this was intentional AFAIK](https://issues.apache.org/jira/browse/SOLR-8029?focusedCommentId=14740121&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14740121), things like `MODIFYCOLLECTION` in V2 API are still POSTs requests). I think I'd rather keep consistency with other APIs than make this particular one better? > I also think that the default behavior should be that files that aren't present in the new configSet should be removed. I was planning to add that as a different PR but also making it not-default, mostly because it can be pretty destructive (i.e. you created the zip file incorrectly, or created it with the "conf" directory on top or something like that it could remove all files) but I'm fine if people think it should be the default. Also, are you OK with doing that as a different PR or want me to do the change here? My intention was to keep the PR small for easier reviews, but if we think this feature is incomplete without that I can do it here too, I'm fine either way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
