[ 
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197315#comment-17197315
 ] 

Noble Paul edited comment on SOLR-14151 at 9/17/20, 1:47 AM:
-------------------------------------------------------------

[~tflobbe]

These are just test failures  due to object leaks and not test failures 
themselves. The tests are passing and the post-test cleanups are failing

A combination of CoreContainer shutdown + core reload is when this results in a 
resource leak. Does it affect a real user? NO . They are shutting down their 
server and there will be no leaks

We really need to get to the bottom of this . There are 3 options

* fix core reloading issues. Me and Erick worked on this several days and we 
still do not see an elegant solution
* avoid managed schema doing core reloads. There is a 
[PR|https://github.com/apache/lucene-solr/pull/1880]
* revert this
I do not wish to go with # 3 . This is an extremely important feature.


was (Author: noble.paul):
[~tflobbe]

These are just test failures  due to object leaks and not test failures 
themselves. The tests are passing and the post-test cleanups are failing

We really need to get to the bottom of this . There are 3 options

* fix core reloading issues. Me and Erick worked on this several days and we 
still do not see an elegant solution
* avoid managed schema doing core reloads. There is a 
[PR|https://github.com/apache/lucene-solr/pull/1880]
* revert this
I do not wish to go with # 3 . This is an extremely important feature.

> Make schema components load from packages
> -----------------------------------------
>
>                 Key: SOLR-14151
>                 URL: https://issues.apache.org/jira/browse/SOLR-14151
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>              Labels: packagemanager
>             Fix For: 8.7
>
>          Time Spent: 12h 50m
>  Remaining Estimate: 0h
>
> Example:
> {code:xml}
>  <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
>     <analyzer type="index">
>       <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
>       <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" 
> generateNumberParts="0" catenateWords="0"
>               catenateNumbers="0" catenateAll="0"/>
>       <filter class="solr.LowerCaseFilterFactory"/>
>       <filter class="solr.FlattenGraphFilterFactory"/>
>     </analyzer>
>   </fieldType>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed, 
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components 
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to