[ 
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198462#comment-17198462
 ] 

Tomas Eduardo Fernandez Lobbe commented on SOLR-14151:
------------------------------------------------------

bq. The reverts are done to an accidental commit I did. not to master 
I think you are confused. This is very much master: 
https://github.com/apache/lucene-solr/commit/27a14fe48139019a4c09ba072751e093fc5cb5f1
 
https://github.com/apache/lucene-solr/commit/cbb1659640cd51be8b403eda8399c527af1c848e,
 you just removed the bot comments from the Jira issue, not the actual commits.

Again, I’m not against this feature, I just want to know what you plan to do 
with the Jenkins failures. You keep saying that this commit didn’t introduce 
the bug, but those tests were passing before and now they aren’t, so something 
needs fixing, and if it will take time, please revert your commits. If this is 
something that only happens in Jenkins, you could push to a branch and have a 
Jenkins job point to it? just an idea

> Make schema components load from packages
> -----------------------------------------
>
>                 Key: SOLR-14151
>                 URL: https://issues.apache.org/jira/browse/SOLR-14151
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>              Labels: packagemanager
>             Fix For: 8.7
>
>          Time Spent: 12h 50m
>  Remaining Estimate: 0h
>
> Example:
> {code:xml}
>  <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
>     <analyzer type="index">
>       <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
>       <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" 
> generateNumberParts="0" catenateWords="0"
>               catenateNumbers="0" catenateAll="0"/>
>       <filter class="solr.LowerCaseFilterFactory"/>
>       <filter class="solr.FlattenGraphFilterFactory"/>
>     </analyzer>
>   </fieldType>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed, 
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components 
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to