arafalov commented on a change in pull request #1894:
URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492270332
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
##########
@@ -139,8 +140,19 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
if (solrCloudMode) {
rsp.add("zkHost", getCoreContainer(req,
core).getZkController().getZkServerAddress());
}
- if (cc != null)
- rsp.add( "solr_home", cc.getSolrHome());
+ if (cc != null) {
+ String solrHome = cc.getSolrHome();
+ rsp.add("solr_home", solrHome);
+
+ Path coreRootDirectory = cc.getCoreRootDirectory();
+ if (coreRootDirectory != null) {
+ String coreRootDirectoryString = coreRootDirectory.toString();
+ if (!coreRootDirectoryString.equals(solrHome)) {
Review comment:
Ok, I was on borderline myself. I felt that because this option is
barely used, having the same long string sent twice was bit of a waste of
bandwidth. But, I guess it does not happen too often.
I can correct both generation and invocation of this option to make it a
guaranteed setup. Let's just hope they don't run version 9 tool against version
8 core.
Also, if you don't like the name (the other open point), this is a good time
to mention it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
