sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r491867642
########## File path: solr/core/src/java/org/apache/solr/cluster/events/CollectionsAddedEvent.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.events; + +import java.util.Collection; + +/** + * Event generated when some collections have been added. + */ +public interface CollectionsAddedEvent extends ClusterEvent { + + @Override + default EventType getType() { + return EventType.COLLECTIONS_ADDED; + } + + Collection<String> getCollectionNames(); Review comment: Ok. ########## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterEventListener.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.events; + +import java.util.Set; + +/** + * Components that want to be notified of cluster-wide events should use this. + * + * XXX should this work only for ClusterSingleton-s? some types of events may be + * XXX difficult (or pointless) to propagate to every node. + */ +public interface ClusterEventListener { + + /** + * The types of events that this listener can process. + */ + Set<ClusterEvent.EventType> getEventTypes(); Review comment: Ok. ########## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterEventProducer.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.events; + +import org.apache.solr.cloud.ClusterSingleton; + +import java.util.Collections; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +/** + * Component that produces {@link ClusterEvent} instances. + */ +public interface ClusterEventProducer extends ClusterSingleton { + + String PLUGIN_NAME = "clusterEventProducer"; + + /** + * Returns a modifiable map of event types and listeners to process events + * of a given type. + */ + Map<ClusterEvent.EventType, Set<ClusterEventListener>> getEventListeners(); Review comment: `EnumMap` is a concrete class, if we specify just a `Map` here then implementations are free to use whatever impl they want. ########## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterPropertiesChangedEvent.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.events; + +import java.util.Map; + +/** + * Event generated when {@link org.apache.solr.common.cloud.ZkStateReader#CLUSTER_PROPS} is modified. + */ +public interface ClusterPropertiesChangedEvent extends ClusterEvent { + + @Override + default EventType getType() { + return EventType.CLUSTER_PROPERTIES_CHANGED; + } + + Map<String, Object> getOldClusterProperties(); Review comment: Ok, makes sense. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
