Hronom commented on a change in pull request #1864:
URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797
##########
File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java
##########
@@ -94,6 +94,12 @@ protected ShardRequest
doRetrieveStatsRequest(ResponseBuilder rb) {
protected void doMergeToGlobalStats(SolrQueryRequest req,
List<ShardResponse> responses) {
Set<Term> allTerms = new HashSet<>();
for (ShardResponse r : responses) {
+ if
("true".equalsIgnoreCase(req.getParams().get(ShardParams.SHARDS_TOLERANT)) &&
r.getException() != null) {
Review comment:
@sigram @madrob I added test that reproduces the problem in
`TestExactStatsCache`. And it fails with null exception if you remove my fix.
Please can you adjust it(if needed) to nicely fit in solr tests suits, I set
now `Allow edits by maintainers`.
The trick here with this issue, that its reproducible only when at least one
shard is fully down(no healthy replica there). This is why I didn't use
`setDistributedParams`, since it's add's one work replica, so all shards is
healthy and there no situation when one shard is completely down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
