s1monw commented on a change in pull request #1925:
URL: https://github.com/apache/lucene-solr/pull/1925#discussion_r495779250
##########
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##########
@@ -2933,7 +2933,7 @@ public void testFlushLargestWriter() throws IOException,
InterruptedException {
int numRamDocs = w.numRamDocs();
int numDocsInDWPT = largestNonPendingWriter.getNumDocsInRAM();
assertTrue(w.flushNextBuffer());
- assertTrue(largestNonPendingWriter.hasFlushed());
+ assertEquals(DocumentsWriterPerThread.State.FLUSHED,
largestNonPendingWriter.getState());
Review comment:
I guess it would. I am not sure if we should really add more methods
just for tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
