madrob commented on a change in pull request #1932: URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497719525
########## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ########## @@ -124,6 +126,17 @@ protected volatile static PerThreadExecService testExecutor; + private static final CryptoKeys.RSAKeyPair reusedKeys = new CryptoKeys.RSAKeyPair(); Review comment: Why not use the key-pair that's already on disk? See https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java#L289-L290 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org