ctargett commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-706344707
+1 this looks good. I think the `solr/solr-ref-guide/README.adoc` also needs to be updated, though. This just occurred to me today, sorry to add another thing. It's really out of date since the move to Gradle so if you prefer to go ahead with merging this I can pick up fixing the README separately. Up to you. When I ran Jekyll locally in my earlier work with this, I needed to upgrade Ruby to 2.7 (the one that came with my OS was 2.3.x). Jekyll 3 does not run on Ruby 2.7, so if we don't make parallel changes in branch_8x for the Ant build, we'll get ourselves stuck when we need to do local builds for 8.x releases of the Ref Guide (it's been a pain today!). I'll take a stab at a new PR on this same SOLR-14900 for that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
