noblepaul commented on a change in pull request #1964:
URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r503040260
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -168,6 +172,33 @@ public CoreLoadFailure(CoreDescriptor cd, Exception
loadFailure) {
}
}
+ public static class ClusterSingletons {
Review comment:
There is no need for `CoreContainer` to be aware of `ClusterSingleton`
Only `ContainerPlugins` and `Overseer` need to be aware of it
##########
File path: solr/core/src/java/org/apache/solr/api/AnnotatedApi.java
##########
@@ -85,9 +85,18 @@ public EndPoint getEndPoint() {
}
public static List<Api> getApis(Object obj) {
- return getApis(obj.getClass(), obj);
+ return getApis(obj.getClass(), obj, true);
}
- public static List<Api> getApis(Class<? extends Object> theClass , Object
obj) {
+
+ /**
+ * Get a list of Api-s supported by this class.
+ * @param theClass class
+ * @param obj object of this class (may be null)
+ * @param required if true then an exception is thrown if no Api-s can be
retrieved, if false
+ * then absence of Api-s is silently ignored.
+ * @return list of discovered Api-s
+ */
+ public static List<Api> getApis(Class<? extends Object> theClass , Object
obj, boolean required) {
Review comment:
`required` ?
I was confusedf
`allowEmpty`?
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java
##########
@@ -51,7 +51,7 @@
public class ContainerPluginsApi {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- public static final String PLUGIN = "plugin";
+ public static final String PLUGINS = "plugin";
Review comment:
why change the variable name at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
