cpoerschke commented on a change in pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r505680828
##########
File path: solr/solr-ref-guide/src/metrics-reporting.adoc
##########
@@ -534,15 +534,34 @@ These metrics are available only on a per-core basis.
Metrics can be aggregated
These metrics are collected in respective registries for each core (e.g.,
`solr.core.collection1....`), under the `INDEX` category.
-Basic metrics are always collected - collection of additional metrics can be
turned on using boolean parameters in the `/config/indexConfig/metrics` section
of `solrconfig.xml`:
+Metrics collection is controlled by boolean parameters in the
`/config/indexConfig/metrics` section of `solrconfig.xml`:
+
Review comment:
Interesting find! Yes, I can see that above the _"The metrics available
in your system can be customized by modifying the `<metrics>` element in
`solr.xml`."_ wording is used and `<metrics>` is more pleasant to read than
`/config/indexConfig/metrics` though that's subjective of course. The context
helps differentiate between the different `<metrics>` elements and so yes, I
agree it would be less jarring (and shorter!) to not use the fully qualified
XML path here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
