sarowe commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709591352
> @sarowe I think I've addressed your concerns LMK if you have further thoughts Yes you have, with one exception: I left a comment that AFAICT you haven't addressed: > .../TypeAsSynonymFilter.java > Consider adding the new features to the class comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
