TomMD commented on a change in pull request #1997:
URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r507963519
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -415,19 +415,15 @@ private void fetchIndex(SolrParams solrParams,
SolrQueryResponse rsp) throws Int
}
static Long getCheckSum(Checksum checksum, File f) {
- FileInputStream fis = null;
checksum.reset();
byte[] buffer = new byte[1024 * 1024];
int bytesRead;
- try {
- fis = new FileInputStream(f);
+ try (final FileInputStream fis = new FileInputStream(f)) {
while ((bytesRead = fis.read(buffer)) >= 0)
checksum.update(buffer, 0, bytesRead);
return checksum.getValue();
} catch (Exception e) {
Review comment:
@dweiss Are we talking about the same code? The pull request / commit
Muse commented on actually deleted the finally block and its `closeQuietly`
call. [Here is the code
analyzed](https://github.com/apache/lucene-solr/blob/c244474b2d3934a4b3d1ee2fbb419cf90605495d/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java#L421)
which was flagged with the bug.
That change was subsequently reverted by @anver-trip (commit 8a10d1b) so
this PR no longer has the bug in the comment. Github helpfully adds an
"Outdated" tag to comments that are on lines which have changed, such as this
one.
Please let me know if I've misunderstood the situation or we can make things
flow more smoothly!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
