dsmiley commented on a change in pull request #1996:
URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509667053
##########
File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java
##########
@@ -133,6 +134,62 @@ public void create(PayloadObj<CreateConfigInfo> obj)
throws Exception {
}
+ @EndPoint(method = POST,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSet(SolrQueryRequest req, SolrQueryResponse rsp)
throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = PUT,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSetWithOverwrite(SolrQueryRequest req,
SolrQueryResponse rsp) throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"),
+ ConfigSetParams.OVERWRITE, true,
+ ConfigSetParams.CLEANUP,
req.getParams().getBool(ConfigSetParams.CLEANUP, false));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = POST,
Review comment:
People can add basically whatever named files they want and reference
them from the primary config files (e.g. solrconfig.xml). This discussion is
similar to field naming in our schema. Some names are special, like
`_version_`. If you try to have your own field named as such, then you're
asking for trouble. Likewise, we might suggest that users avoid file names
with a leading underscore. Simple enough and keeps the "/files" verbosity out.
Also there is a difference in HTTP verbs... in this issue here we're using PUT
to put a file. But for an interactive editing of config elements, that would
use POST.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]