[
https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224194#comment-17224194
]
Bar Rotstein edited comment on SOLR-14963 at 10/31/20, 9:50 PM:
----------------------------------------------------------------
Yes,
I do believe the default "limit" should be unlimited.
I was thinking about approaching the implementation of "limit" to only limit
the immediate child documents, and return all descendants of these immediate
children (if any) that match the childFilter.
Do you think a better approach would be if limit applied on a per level basis?
I was just thinking, usually if you do not wish to get descendants lower than a
certain level, you would probably use a different childFilter, so the
transformer might as well return all children of the immediate children that
made it through the limit and match childFilter.
I even made a rough implementation of this PR:
https://github.com/apache/lucene-solr/pull/2043
WDYT, [~dsmiley] [~arafalov]?
was (Author: brot):
Yes,
I do believe the default "limit" should be unlimited.
I was thinking about approaching the implementation of "limit" to only limit
the immediate child documents, and return all descendants of these immediate
children (if any) that match the childFilter.
Do you think a better approach would be if limit applied on a per level basis?
I was just thinking, usually if you do not wish to get descendants lower than a
certain level, you would probably use a different childFilter, so the
transformer might as well return all children of the immediate children that
made it through the limit and match childFilter.
WDYT, [~dsmiley] [~arafalov]?
> Child "rows" param should apply per level
> -----------------------------------------
>
> Key: SOLR-14963
> URL: https://issues.apache.org/jira/browse/SOLR-14963
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Major
>
> The {{[child rows=10]}} doc transformer "rows" param _should_ apply per
> parent, and it's documented this way: "The maximum number of child documents
> to be returned per parent document.". However, it is instead implemented as
> an overall limit as the child documents are processed in a depth-first order
> way. The implementation ought to change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
