murblanc commented on a change in pull request #1962: URL: https://github.com/apache/lucene-solr/pull/1962#discussion_r517213017
########## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/ClusterEventProducerFactory.java ########## @@ -0,0 +1,173 @@ +package org.apache.solr.cluster.events.impl; + +import org.apache.solr.api.ContainerPluginsRegistry; +import org.apache.solr.cluster.events.ClusterEvent; +import org.apache.solr.cluster.events.ClusterEventListener; +import org.apache.solr.cluster.events.ClusterEventProducer; +import org.apache.solr.cluster.events.ClusterEventProducerBase; +import org.apache.solr.cluster.events.NoOpProducer; +import org.apache.solr.core.CoreContainer; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.lang.invoke.MethodHandles; +import java.util.Set; + +/** + * This class helps in handling the initial registration of plugin-based listeners, + * when both the final {@link ClusterEventProducer} implementation and listeners + * are configured using plugins. + */ +public class ClusterEventProducerFactory extends ClusterEventProducerBase { Review comment: This class is only used by a single thread, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org