HoustonPutman commented on a change in pull request #2055:
URL: https://github.com/apache/lucene-solr/pull/2055#discussion_r517610328
##########
File path: solr/bin/solr
##########
@@ -2172,6 +2172,16 @@ function start_solr() {
SOLR_OPTS+=($AUTHC_OPTS)
fi
+ # If a heap dump directory is specified, enable it in SOLR_OPTS
+ if [[ -z "$SOLR_HEAP_DUMP_DIR" ]] && [[ "$SOLR_HEAP_DUMP" == "true" ]]; then
+ SOLR_HEAP_DUMP_DIR="${SOLR_LOGS_DIR}/dumps"
+ fi
+ if [[ -n "$SOLR_HEAP_DUMP_DIR" ]]; then
+ SOLR_OPTS+=("-XX:+HeapDumpOnOutOfMemoryError")
+ SOLR_OPTS+=("-XX:HeapDumpPath=$SOLR_HEAP_DUMP_DIR/solr-$(date
+%s)-pid$$.hprof")
+ mkdir -p "$SOLR_HEAP_DUMP_DIR" 2>/dev/null
Review comment:
Why are you piping the errors here? `mkdir -p` should be safe right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
