[ 
https://issues.apache.org/jira/browse/LUCENE-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227753#comment-17227753
 ] 

Dawid Weiss commented on LUCENE-8982:
-------------------------------------

Hi Zach. I don't think we've ported this particular build fragment from ant - 
thank you for contributing it. It can be a separate module but I think it 
shouldn't be forced upon everyone on default convention tasks (assemble, check) 
- I didn't check if it's currently the case. Native builds require extra setup 
and tools that some platforms may lack (Windows, Mac). If it's the case that 
these tasks run by default is then we'll need to add either an explicit 
property (-Pbuild.native=true?) or a dedicated task (native) and make the build 
conditional on whether it is explicitly defined.

I can take a look if you have a problem with this, let me know.

> Make NativeUnixDirectory pure java now that direct IO is possible
> -----------------------------------------------------------------
>
>                 Key: LUCENE-8982
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8982
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/misc
>            Reporter: Michael McCandless
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{NativeUnixDirectory}} is a {{Directory}} implementation that uses direct IO 
> to write newly merged segments.  Direct IO bypasses the kernel's buffer cache 
> and write cache, making merge writes "invisible" to the kernel, though the 
> reads for merging the N segments are still going through the kernel.
> But today, {{NativeUnixDirectory}} uses a small JNI wrapper to access the 
> {{O_DIRECT}} flag to {{open}} ... since JDK9 we can now pass that flag in 
> pure java code, so we should now fix {{NativeUnixDirectory}} to not use JNI 
> anymore.
> We should also run some more realistic benchmarks seeing if this option 
> really helps nodes that are doing concurrent indexing (merging) and searching.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to