[
https://issues.apache.org/jira/browse/SOLR-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230138#comment-17230138
]
Jason Gerlowski commented on SOLR-14971:
----------------------------------------
On the github PR, Munendra pointed out that this downside also affects the
'add-distinct' operation, so the commits above fix that too.
Munendra proposed an alternative approach to what I ended up going with that
might be worth looking into in the future. He suggested having the 'original'
collection of field values iterated over and converted using 'toNativeType'.
This would ensure that the needle and haystack are all of the same Java type so
to speak and would save us a lot of manual type checking. I liked this better
conceptually but wasn't confident enough about what effect changing the type of
ALL the uncommitted field values might have downstream to pursue it in this PR.
If other cases are found though the ugliness of the type checking might make
this worth a second look though.
Closing this out.
> AtomicUpdate 'remove' fails on 'pints' fields
> ---------------------------------------------
>
> Key: SOLR-14971
> URL: https://issues.apache.org/jira/browse/SOLR-14971
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: update
> Affects Versions: 8.5.2
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Attachments: reproduce.sh
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The "remove" atomic update action on multivalued int fields fails if the
> document being changed is uncommitted.
> At first glance this appears to be a type-related issue.
> AtomicUpdateDocumentMerger attempts to handle multivalued int fields by
> processing the List<Integer> type, but in uncommitted docs int fields are
> still List<String> in the tlog. Conceptually this feels similar to
> SOLR-13331.
> It's likely this issue also affects other numeric and date fields.
> Attached is a simple script to reproduce, meant to be run from the root of a
> Solr install.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
