uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729034044
> Hmm, maybe this is a good reason to make this change in two steps (add pure java version, then, later, remove native one)? Which platforms will now throw UnsupportedOperationException with this new pure-java solution? It works on more platforms than the old NativeUnixDirectory. So please remove that one! And if you do it already, also remove WindowsDirectory :-) It works on the main Java platforms supported by OpenJDK, but the flag is not part of the "Java standard",. One good thing: The JDK version also works on Windows, where the handwritten native version was not able to work (different POSIX vs. Win32 API). So we can test it on Jenkins, too. I just say: The documentation should be corrected that it does explicitely say that it may not work on all platforms or JDK versions. The ExtendedOpenOption is an internal API (see `@SuppressForbidden`) and it is documenteted that the flags are platform dependent. It may for example also not work on NFS, who knows! Of course if somebody gets an UOE, one knows that it doesnt work. We should just document it, like we documented that the native variant does not work on all platforms. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
