thelabdude commented on a change in pull request #2067: URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r527027557
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java ########## @@ -334,11 +334,6 @@ private StreamComparator parseComp(String sort, String fl) throws IOException { public static Slice[] getSlices(String collectionName, ZkStateReader zkStateReader, boolean checkAlias) throws IOException { ClusterState clusterState = zkStateReader.getClusterState(); - Map<String, DocCollection> collectionsMap = clusterState.getCollectionsMap(); - - //TODO we should probably split collection by comma to query more than one - // which is something already supported in other parts of Solr - // check for alias or collection Review comment: Moved the call to getAliases out of the for loop ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org