[ https://issues.apache.org/jira/browse/SOLR-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235656#comment-17235656 ]
Christine Poerschke commented on SOLR-13671: -------------------------------------------- bq. ... lucene/tools/src/groovy/check-source-patterns.groovy ... I see the file got renamed in the https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=def82ab commit on {{master}} branch but remains present on {{branch_8x}} branch. [~erickerickson], do you perhaps recall if the changes in this JIRA task here were intended for {{master}} branch or {{branch_8x}} or both? Usually -- https://cwiki.apache.org/confluence/display/SOLR/HowToContribute -- our development is on master branch and then gets backported, but perhaps this scenario here is different (I haven't looked yet at the discussion in the linked JIRA) and I note that [~Alexey Bulygin]'s patch can be {{cd lucene ; git apply}} applied to branch_8x, hence asking. Hope that helps. > Remove check for bare "var" declarations in validate-source-patterns in > before releasing Solr 9.0 > ------------------------------------------------------------------------------------------------- > > Key: SOLR-13671 > URL: https://issues.apache.org/jira/browse/SOLR-13671 > Project: Solr > Issue Type: Improvement > Reporter: Erick Erickson > Priority: Blocker > Fix For: master (9.0) > > Attachments: SOLR-13671.patch > > > See the discussion in the linked JIRA. > Remove the line: > (~$/\n\s*var\s+/$) : 'var is not allowed in until we stop development on the > 8x code line' > in > invalidJavaOnlyPatterns > from lucene/tools/src/groovy/check-source-patterns.groovy -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org