[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240609#comment-17240609
]
Uwe Schindler edited comment on LUCENE-9623 at 11/30/20, 9:55 AM:
------------------------------------------------------------------
By the way, this is why the following issue was a requirement to enable module
system: LUCENE-9281 (our old SPIClassIterator was not able to use the module
system). Now this all fits nicely together.
We just need BOTH, the META-INF/services for Classpath applications, but also
the new "provides" statements in moudle info for applications using module
system.
We should find a way to maybe have some templating system for the
module-info.java:
- services are automatically included based on META-INF/services (to not
maintain them duplicate).
- exports are done manual
- imports maybe based on Gradle dependencies?
was (Author: thetaphi):
By the way, this is why this issues was a requirement to enable moudle systems:
LUCENE-9281 (our old SPIClassIterator was not able to use the module system).
Now this all fits nicely together.
We just need BOTH, the META-INF/services for Classpath applications, but also
the new "provides" statements in moudle info for applications using module
system.
> Add module descriptor (module-info.java) to lucene jars
> -------------------------------------------------------
>
> Key: LUCENE-9623
> URL: https://issues.apache.org/jira/browse/LUCENE-9623
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Affects Versions: master (9.0)
> Reporter: Tomoko Uchida
> Priority: Major
> Attachments: generate-all-module-info.sh
>
>
> For a starter, module descriptors can be automatically generated by jdeps
> utility.
> There are two choices.
> 1. generate "open" modules which allows reflective accesses with
> --generate-open-module option
> 2. generate non-open modules with --generate-module-info option
> Which is the better - not fully sure, but maybe 2 (non-open modules)?
> Also, we need to choose proper module names - just using gradle project path
> for it is OK?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
