gf2121 opened a new pull request #2106: URL: https://github.com/apache/lucene-solr/pull/2106
# Description in [LUCENE-9027|https://github.com/apache/lucene-solr/pull/973] lucene introduced SIMD to decode postings, which leaves a very small problem. since this is a hot way when indexing and searching, so fixing it may make a bit sense. i hope i can fix this problem as my first PR on this amazing project :) detail: ``` maxUnpatchedValue has already computed apache.lucene.codecs.lucene84.PForUtil#encode line 64 final long maxUnpatchedValue = (1L << patchedBitsRequired) - 1; apache.lucene.codecs.lucene84.PForUtil#encode line 74 but computed later again: if (longs[i] > (1L << patchedBitsRequired) - 1) ... ``` # Solution ``` convert apache.lucene.codecs.lucene84.PForUtil#encode line 74 if (longs[i] > (1L << patchedBitsRequired) - 1) ... to if (longs[i] > maxUnpatchedValue) ... ``` # Tests none # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
