[ https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-9624. ---------------------------------- Fix Version/s: 8.8 Resolution: Fixed > fix duplicate compute on maxUnpatchedValue > ------------------------------------------ > > Key: LUCENE-9624 > URL: https://issues.apache.org/jira/browse/LUCENE-9624 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs > Reporter: Feng Guo > Priority: Major > Fix For: 8.8 > > Time Spent: 0.5h > Remaining Estimate: 0h > > in [LUCENE-9027|[https://github.com/apache/lucene-solr/pull/973]] lucene > introduced SIMD to decode postings, which leaves a very small problem. i hope > i can fix this as my first PR on this amazing project :). > detail: > {code:java} > maxUnpatchedValue has already computed > apache.lucene.codecs.lucene84.PForUtil#encode line 64 > final long maxUnpatchedValue = (1L << patchedBitsRequired) - 1; > apache.lucene.codecs.lucene84.PForUtil#encode line 74 > but computed later again: > if (longs[i] > (1L << patchedBitsRequired) - 1)...{code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org