jpountz commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-735763595
> what I understand is the files read by for example
CompressingStoredFieldsReader, they hold versioning in the header?
When we want to make changes to a file format we have two options:
1. Either we create a new one and use it in a new codec, the old one only
being used for bw compat.
2. Or we handle this internally by incrementing the internal version of the
file format.
In general we lean towards 1 for the bigger changes and 2 for the smaller
changes. For this change of endianness, we could decide to use option 1 across
all file formats so that a given file format always knows what endianness it's
supposed to use up-front.
So in the example you mentionned, we could create a new
Lucene90StoredFieldsFormat that doesn't share any logic with the current stored
fields format and always writes and reads data in little endian order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
