jimczi commented on a change in pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#discussion_r535253273
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -360,8 +352,8 @@ protected void updateMinCompetitiveScore(Scorable scorer)
throws IOException {
if (canSetMinScore
&& queueFull
&& hitsThresholdChecker.isThresholdReached()) {
- assert bottom != null && relevanceComparator != null;
- float minScore = relevanceComparator.value(bottom.slot);
+ assert bottom != null;
+ float minScore = ((FieldComparator.RelevanceComparator)
firstComparator).value(bottom.slot);
Review comment:
Can we avoid the cast here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
