sigram commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536353469
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java ########## @@ -17,15 +17,39 @@ package org.apache.solr.cluster.placement; +import org.apache.solr.api.ConfigurablePlugin; + /** - * Factory implemented by client code and configured in {@code solr.xml} allowing the creation of instances of + * Factory implemented by client code and configured in container plugins allowing the creation of instances of Review comment: I'll add a reference to `ContainerPluginsApi#Edit` - JSON formats and the location of the config in `/clusterprops.json` are an implementation detail. Also, container plugin configuration is/will be described in the RefGuide (SOLR-15022). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org