mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-744527462


   Alas, `gradlew precommit` from the command-line on Linux box is still angry 
for me:
   
   ```
   > Task :lucene:misc:compileJava
   
/l/trunk/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java:163:
 warning: ExtendedOpenOption is internal proprietary API and may be removed in 
a future release
                                     
com.sun.nio.file.ExtendedOpenOption.DIRECT);
                                                     ^
   
/l/trunk/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java:282:
 warning: ExtendedOpenOption is internal proprietary API and may be removed in 
a future release
         channel = FileChannel.open(path, StandardOpenOption.READ, 
com.sun.nio.file.ExtendedOpenOption.DIRECT);
                                                                                
   ^
   error: warnings found and -Werror specified
   ```
   
   Oh I see -- you are using `@SuppressForbidden`  (which is indeed necessary, 
since we are using an API that we otherwise forbid!), but you must also add 
`@SuppressWarnings("sunapi")` to suppress `javac` warnings.  Lots of 
suppression happening here!!  Hmm, but when I tried adding those two lines 
locally, `gradlew precommit` still fails, hrmph.
   
   This might be a JDK difference -- I'm using JDK 15.
   
   Hmm, a little more research uncovers 
[JDK-6476630](https://bugs.openjdk.java.net/browse/JDK-6476630), which makes it 
sound like it is not possible to suppress this particular warning.  Now I'm not 
sure what to do!  Need @uschindler help again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to