zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748563011
Oh wow thanks for the updates there, and sorry to hear the current changes are not yet ready! Yes the original implementation hasn't been used for a while now (as native code compilation is not available after Ant migration), and the DirectIO test was a recent addition as part of the work for this jira ticket. I read through all the comments and some code changes, and the main issues highlighted are: 1. On Windows, alignment is done differently from Linux, and thus the aligned slice size could be smaller than the intended buffer size. This caused problems when we also keep track of buffer manipulation stats using fields outside of aligned byte buffer. So the strategy for fixing here is to resort to ByteBuffer's fields and methods to correctly track the position, limit, mark, capacity etc for buffer manipulation. 2. Some essential methods like `getChecksum` is not implemented (is this interface added after initial Unix Directory?), and since the tests mostly exercise delegate's methods (which are already functioning), and the one that does exercise DirectIO is not using a real index, so the tests didn't discover the implementation is broken. The strategy for fixing here is to force all the tests to also use DirectIO and making sure the implementation passes all of them. Would love to help but don't want to get in the way of your plan either. Please let me know if there's anything you would like me to work on. Appreciate again your help on this @uschindler ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
