tflobbe commented on a change in pull request #2169:
URL: https://github.com/apache/lucene-solr/pull/2169#discussion_r549576007



##########
File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-caching.xml
##########
@@ -21,19 +21,16 @@
   <schemaFactory class="ClassicIndexSchemaFactory"/>
   <query>
     <cache name="lfuCacheDecayFalse"

Review comment:
       I think we shouldn't be changing this file. It's specific for the 
LFUCache testing, so we should leave it as is. 

##########
File path: solr/server/solr/configsets/_default/conf/solrconfig.xml
##########
@@ -416,8 +416,7 @@
                       to occupy. Note that when this option is specified, the 
size
                       and initialSize parameters are ignored.
       -->

Review comment:
       Could you fix this docs to state that the default cache class is 
`CaffeineCache`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to