msokolov commented on pull request #2173: URL: https://github.com/apache/lucene-solr/pull/2173#issuecomment-752752365
At @rmuir's suggestion, I re-coded as JMH benchmark, with a similar result: ``` Benchmark Mode Cnt Score Error Units TestIndexInputReadFloats.testIndexInputReadFloats thrpt 25 1371.856 ± 11.681 ops/s TestLuceneBaseline.testLuceneBaseline thrpt 25 572.370 ± 3.918 ops/s TestOnHeapArray.testOnHeapArray thrpt 25 1915.688 ± 1.233 ops/s ``` It seems as if a large benefit can be had by implementing `IndexInput.readFloats`, so I'll work that up, but there's still some fairly big gap with on-heap arrays. Maybe some kind of loop-unrolling / vectorization? I'll look at asm and see what I can tease out of that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
