murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552215235
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -242,6 +260,37 @@ public PlacementPlan computePlacement(Cluster cluster,
PlacementRequest request,
}
}
+ if (secondaryCollection != null) {
Review comment:
Also, comment on that method that the approach is a rather simplistic
one, since the set of nodes chosen for the placement request does not take into
account the existing `secondaryCollection` distribution, possibly leading to
the creation of replicas for that collection that could have been avoided.
I assume clusters where such `withCollection` tricks are done can restrict
placement of both collections to a set of nodes to better control what's going
on...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
