zacharymorn commented on pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#issuecomment-755104110
> I left some comments but it looks great in general. Could you add more tests as well, e.g. a variant of TestWANDScorer#testBasics that configures a minShouldMatch of 2? Thanks for the review and comments! I've added a variant of `TestWANDScorer#testBasics` and broke it apart into 3 separate test methods. I also ran `gradlew :lucene:core:spotlessApply` to do some auto formatting in order to keep the build / validation happy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
