[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261668#comment-17261668 ]
Tim Dillon commented on SOLR-15025: ----------------------------------- [~mdrob] I'm a new dev and would be interested in working on this if it is available. I'm looking at {{waitForAllNodes}} and I see that its creating a {{TimeOut}} with 30 seconds, but the various calls to the method are all passing a {{timeoutSeconds}} argument. I replaced the hard coded 30 with the {{timeoutSeconds}} variable and the tests passed. Would that be a sufficient fix? Also would it be better to check if {{timeoutSeconds}} is null and if so, provide a default value such as 30? > MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value > ----------------------------------------------------------------- > > Key: SOLR-15025 > URL: https://issues.apache.org/jira/browse/SOLR-15025 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests > Reporter: Mike Drob > Priority: Major > Labels: beginner, newdev > > the api could also expand to take a time unit? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org