cammiemw commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r555482893
##########
File path: lucene/core/src/java/org/apache/lucene/search/ScoreAndDoc.java
##########
@@ -32,4 +33,9 @@ public int docID() {
public float score() {
return score;
}
+
+ @Override
+ public float smoothingScore(int docId) throws IOException {
Review comment:
I agree that this makes more sense ;-) I have added the default
implementation of smoothingScore in Scorable and reverted my changes to add the
smoothingScore method to all the unnecessary extending classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
