dweiss commented on a change in pull request #2229:
URL: https://github.com/apache/lucene-solr/pull/2229#discussion_r562496757
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -588,6 +585,12 @@ private boolean checkCondition(
return stems;
}
+ private boolean isFlagAppendedByAffix(int affixId, char flag) {
+ if (affixId < 0) return false;
Review comment:
Required is not the right word... Perhaps... advised. :) You are
entitled to your own opinion (at least as long as this passes precommit
checks!) - like I said, I relayed what's been mentioned on the mailing list.
Some people just put braces everywhere and they are used to this consistency,
even if it adds verbosity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
