iverase commented on a change in pull request #2245:
URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564545408
##########
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java
##########
@@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput
input, byte b) throws IOE
}
}
+ /**
+ * Note: although this format is only used on older versions, we need to
keep the write logic
Review comment:
Thanks @mikemccand for the clarification.
I was thinking what would happen if a user opens an old index/segment and
adds a new document that contains a vector field. You are suggesting that in
that case a totally new segment would be created. This method is only called in
the case you mention above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
