megancarey commented on a change in pull request #2265:
URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r566495456
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
##########
@@ -407,15 +432,6 @@ public boolean split(ClusterState clusterState,
ZkNodeProps message, NamedList<O
log.debug("Successfully applied buffered updates on : {}",
subShardNames);
- // Replica creation for the new Slices
-
- Set<String> nodes = clusterState.getLiveNodes();
- List<String> nodeList = new ArrayList<>(nodes.size());
- nodeList.addAll(nodes);
-
- // Remove the node that hosts the parent shard for replica creation.
- nodeList.remove(nodeName);
Review comment:
Also cleaned this up because it was bugging me :) nodeList is never used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
