[
https://issues.apache.org/jira/browse/SOLR-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276513#comment-17276513
]
Christine Poerschke commented on SOLR-11233:
--------------------------------------------
{quote}... a new {{GC_LOG_FILE_OPTS}} option ...
{quote}
[https://github.com/apache/lucene-solr/pull/2284] proposes to name the new
option {{JAVA8_GC_LOG_FILE_OPTS}} to make it clear that it's Java8 specific
only (and the option would go away in Solr 9 which does not support Java8).
Help with making and testing the equivalent Windows i.e. {{solr.cmd}} changes
would be appreciated.
Here's what I used for local testing:
{code:java}
export JAVA_HOME=$JAVA8_HOME
ant clean
cd solr ; ant server
export JAVA8_GC_LOG_FILE_OPTS='-Xloggc:./solr_gc.log -XX:+UseGCLogFileRotation
-XX:NumberOfGCLogFiles=9 -XX:GCLogFileSize=10K'
bin/solr start -e techproducts
ps -ef | grep java | less
ls -ltrh `find . -name "*solr_gc.log*"`
bin/post -c techproducts ../solr/example/exampledocs
ls -ltrh `find . -name "*solr_gc.log*"`
bin/solr stop
{code}
> GC_LOG_OPTS customisation is a little confusing
> -----------------------------------------------
>
> Key: SOLR-11233
> URL: https://issues.apache.org/jira/browse/SOLR-11233
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-11233.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{GC_LOG_OPTS}} customisation is currently supported but (pre Java 9) the
> customised settings are supplemented e.g.
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/bin/solr#L1713
> {code}
> GC_LOG_OPTS+=("$gc_log_flag:$SOLR_LOGS_DIR/solr_gc.log"
> '-XX:+UseGCLogFileRotation' '-XX:NumberOfGCLogFiles=9'
> '-XX:GCLogFileSize=20M')
> {code}
> This seems unexpected and confusing. Some ideas for making it less confusing:
> * a new {{GC_LOG_FILE_OPTS}} option
> ** the new option can be customised but if unset it would default to existing
> behaviour
> * use customised GC_LOG_OPTS 'as is'
> ** this would be a change to existing behaviour i.e. the
> [solr#L1713|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/bin/solr#L1713]
> settings mentioned above would no longer be appended
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
