HoustonPutman commented on a change in pull request #151:
URL:
https://github.com/apache/lucene-solr-operator/pull/151#discussion_r568148914
##########
File path: main.go
##########
@@ -65,6 +69,7 @@ func init() {
_ = solrv1beta1.AddToScheme(scheme)
_ = zkv1beta1.AddToScheme(scheme)
+ _ = certv1.AddToScheme(scheme)
// +kubebuilder:scaffold:scheme
flag.BoolVar(&useZookeeperCRD, "zk-operator", true, "The operator will
not use the zk operator & crd when this flag is set to false.")
Review comment:
Ahh sorry for the confusion.
Yeah, it looks like Solr Operator is creating its own Secrets as well as
finding secrets created by CertManager. If that's the case, then I think we
will need both "Owns" and "Watches" with similar logic to the ConfigMaps. But I
may be wrong there, this is uncharted territory.
Are we sure we don't need to own Certificates? We wait for them to come
online, so we want to be notified when they have condition changes, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
