[ 
https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-15127:
--------------------------------------
    Attachment: SOLR-15127.patch
        Status: Open  (was: Open)


The attached patch implements this idea, and seems to work well -- there are 
some nocommits, but they aren't neccessarily problems that need "fixed", so 
much as comments to draw attention to some specific changes for discussion.

Basic usage is spelled out in the Dockerfile comments...

{noformat}
# This Dockerfile can be used in 2 distinct ways:
# 1) For Solr developers with a java/gradle development env, this file is used 
by gradle to build docker images
#    from your local builds (with or w/o local modifications).  When doing 
this, gradle will use a docker build context
#    containing pre-built artifacts from previous gradle targets
#       EX: ./gradlew -p solr/docker dockerBuild
#
# 2) Solr users, with or w/o a local java/gradle development env, can pass this 
Dockerfile directly to docker build,
#    using the root level checkout of the the project -- or a remote git URL -- 
as the docker build context.  When doing
#    this, docker will invoke gradle to build all neccessary artifacts
#       EX: docker build --file solr/docker/Dockerfile .
#           docker build --file solr/docker/Dockerfile 
https://gitbox.apache.org/repos/asf/lucene-solr.git
#           docker build --file solr/docker/Dockerfile 
https://gitbox.apache.org/repos/asf/lucene-solr.git#branch_9x
#    
# This last format is the method used by Solr Release Managers to build the 
official apache/solr images uploaded to hub.docker.com
#
# EX: docker build --build-arg SOLR_VERSION=9.0.0 \
#                  --tag apache/solr:9.0.0 \
#                  --file solr/docker/Dockerfile \
#                  
https://gitbox.apache.org/repos/asf/lucene-solr.git#releases/lucene-solr/9.0.0
{noformat}

...allthough the direct "docker build" usage could be drastically simplified 
once solr has it's own TLP/git repo if we're willing to keep the Dockerfile in 
the root of the repo.

[~houstonputman] / [~dsmiley] / [~janhoy]: what do you guys think of this 
overall approach?


> All-In-One Dockerfile for building local images as well as reproducible 
> release builds directly from (remote) git tags
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-15127
>                 URL: https://issues.apache.org/jira/browse/SOLR-15127
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-15127.patch
>
>
> There was a recent dev@lucene discussion about the future of the 
> github/docker-solr repo and (Apache) "official" solr docker images and using 
> the "apache/solr" nameing vs (docker-library official) "_/solr" names...
> http://mail-archives.apache.org/mod_mbox/lucene-dev/202101.mbox/%3CCAD4GwrNCPEnAJAjy4tY%3DpMeX5vWvnFyLe9ZDaXmF4J8XchA98Q%40mail.gmail.com%3E
> In that disussion, mak pointed out that docker-library evidently allows for 
> some more flexibility in the way "official" docker-library packages can be 
> built (compared to the rules that were evidnlty in place when the mak setup 
> the current docker-solr image building process/tooling), pointing out how the 
> "docker official" elasticsearch images are current built from the "elastic 
> official" elasticsearch images...
> http://mail-archives.apache.org/mod_mbox/lucene-dev/202101.mbox/%3C3CED9683-1DD2-4F08-97F9-4FC549EDE47D%40greenhills.co.uk%3E
> Based on this, I proposed that we could probably restructure the Solr 
> Dockerfile so that it could be useful for both "local development" -- using 
> the current repo checkout -- as well as for "apache official" apache/solr 
> images that could be reproducibly built directly from pristine git tags using 
> the remote git URL syntax supported by "docker build" (and then -- evidently 
> -- extended by trivial one line Dockerfiles for the "docker-library official" 
> _/solr images)...
> http://mail-archives.apache.org/mod_mbox/lucene-dev/202101.mbox/%3Calpine.DEB.2.21.2101221423340.16298%40slate%3E
> This jira tracks this idea.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to