gerlowskija commented on a change in pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281#discussion_r570308977
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/CreateBody.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.solrj.request.beans; + +import org.apache.solr.common.annotation.JsonProperty; +import org.apache.solr.common.util.ReflectMapWriter; + +import java.util.List; +import java.util.Map; + +public class CreateBody implements ReflectMapWriter { + @JsonProperty(required = true) + public String name; + + @JsonProperty + public String config; + + @JsonProperty + public RouterInfo router; + + @JsonProperty + public Integer numShards; + + @JsonProperty + public String shards; + + @JsonProperty + public Integer replicationFactor; + + @JsonProperty + public Integer nrtReplicas; + + @JsonProperty + public Integer tlogReplicas; + + @JsonProperty + public Integer pullReplicas; + + @JsonProperty + public List<String> nodeSet; + + @JsonProperty + public Boolean shuffleNodes; + + @JsonProperty + public Map<String, Object> properties; + + @JsonProperty + public String async; + + @JsonProperty + public Boolean waitForFinalState; + + @JsonProperty + public Boolean perReplicaState; + + public static class RouterInfo implements ReflectMapWriter { Review comment: Good catch. There's a Jackson annotation made for this case (`JsonAnyGetter`) - named properties will be mapped as usual but "extra" ones are put in a Map or whatever. But it looks like we're not actually using Jackson here to avoid SolrJ needing to depend on Jackson. I could create clone JsonAnyGetter the way we've done with JsonProperty, but idt it's worth it. I'll just remove this RouterInfo class and handle all the properties as a Map for the translation. Might be worth considering whether a Jackson-dep is worth it after all going forward though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
